[libc-commits] [PATCH] D152575: Added modf for NVPTX and AMDGPU targets to implement 'libmgpu.a' for math on the GPU

Jon Chesterfield via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Jun 14 01:16:27 PDT 2023


JonChesterfield added a comment.

The boilerplate to functionality ratio is pretty extreme here. How does the libc subproject feel about code generators?

If we can run python scripts to generate the code at build time, great.

For an out of tree target I remember generating source code in cmake as people didn't like running python at build time.

If neither of those are acceptable, perhaps we should do the X macro thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152575/new/

https://reviews.llvm.org/D152575



More information about the libc-commits mailing list