[libc-commits] [PATCH] D152630: [libc] Enable custom logging in LibcTest

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added a comment.

LGTM with one question.



================
Comment at: libc/test/UnitTest/TestLogger.cpp:69
+template TestLogger &TestLogger::operator<< <int32_t>(int32_t);
+template TestLogger &TestLogger::operator<< <int64_t>(int64_t);
 template TestLogger &TestLogger::operator<< <long long>(long long);
----------------
Why should we use `[u]int<..>_t` types? Could it lead to duplicate declaration errors, for example if `int64_t == long long`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152630/new/

https://reviews.llvm.org/D152630