[libc-commits] [PATCH] D152873: [libc] Enable hermetic floating point tests again.

[Joseph Huber via Phabricator via libc-commits]

jhuber6 added a comment.

With this patch I get the following failures on my AMDGPU machine. I'm not sure if it's something we haven't yet implemented on the GPU or not.

  FAILED: libc/test/src/__support/FPUtil/CMakeFiles/libc.test.src.__support.FPUtil.rounding_mode_test.__hermetic__ /home/jhuber/Documents/llvm/llvm-project/build/runtimes/runtimes-bins/libc/test/src/__support/FPUtil/CMakeFiles/libc.test.src.__support.FPUtil.rounding_mode_test.__hermetic__ 
  cd /home/jhuber/Documents/llvm/llvm-project/build/runtimes/runtimes-bins/libc/test/src/__support/FPUtil && /home/jhuber/Documents/llvm/llvm-project/build/runtimes/runtimes-bins/libc/utils/gpu/loader/amdgpu/amdhsa_loader /home/jhuber/Documents/llvm/llvm-project/build/runtimes/runtimes-bins/libc/test/src/__support/FPUtil/libc.test.src.__support.FPUtil.rounding_mode_test.__hermetic__.__build__
  [ RUN      ] LlvmLibcFEnvImplTest.QuickRoundingUpTest
  /home/jhuber/Documents/llvm/llvm-project/libc/test/src/__support/FPUtil/rounding_mode_test.cpp:22: FAILURE
        Expected: (fenv_is_round_up())
        Which is: 0
  To be equal to: true
        Which is: 1
  [  FAILED  ] LlvmLibcFEnvImplTest.QuickRoundingUpTest
  [ RUN      ] LlvmLibcFEnvImplTest.QuickRoundingDownTest
  /home/jhuber/Documents/llvm/llvm-project/libc/test/src/__support/FPUtil/rounding_mode_test.cpp:46: FAILURE
        Expected: (fenv_is_round_down())
        Which is: 0
  To be equal to: true
        Which is: 1
  [  FAILED  ] LlvmLibcFEnvImplTest.QuickRoundingDownTest
  [ RUN      ] LlvmLibcFEnvImplTest.QuickRoundingNearestTest
  /home/jhuber/Documents/llvm/llvm-project/libc/test/src/__support/FPUtil/rounding_mode_test.cpp:62: FAILURE
        Expected: (fenv_is_round_to_nearest())
        Which is: 1
  To be equal to: false
        Which is: 0
  [  FAILED  ] LlvmLibcFEnvImplTest.QuickRoundingNearestTest
  [ RUN      ] LlvmLibcFEnvImplTest.QuickRoundingTowardZeroTest
  /home/jhuber/Documents/llvm/llvm-project/libc/test/src/__support/FPUtil/rounding_mode_test.cpp:94: FAILURE
        Expected: (fenv_is_round_to_zero())
        Which is: 0
  To be equal to: true
        Which is: 1
  [  FAILED  ] LlvmLibcFEnvImplTest.QuickRoundingTowardZeroTest
  [ RUN      ] LlvmLibcFEnvImplTest.QuickGetRoundTest
  /home/jhuber/Documents/llvm/llvm-project/libc/test/src/__support/FPUtil/rounding_mode_test.cpp:102: FAILURE
        Expected: quick_get_round()
        Which is: 0
  To be equal to: 0x800
        Which is: 2048
  [  FAILED  ] LlvmLibcFEnvImplTest.QuickGetRoundTest
  Ran 5 tests.  PASS: 0  FAIL: 5


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152873/new/

https://reviews.llvm.org/D152873