[libc-commits] [PATCH] D152630: [libc] Enable custom logging in LibcTest

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet added inline comments.


================
Comment at: libc/test/UnitTest/LibcTest.h:53
+template <typename T> struct Matcher : public MatcherBase {
+  bool match(T &t);
+};
----------------
lntue wrote:
> Do you know why the Matcher's interface cannot be `const T&`?  Ideally it should not modify the inputs, right?
I traced it down to https://reviews.llvm.org/D75487
I don't see a rationale for this choice so I assume it was just overlooked.

I refrained from fixing it in this patch to prevent noise but since you're mentioning it, here it is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152630/new/

https://reviews.llvm.org/D152630