[libc-commits] [PATCH] D152563: [libc] Minimal support for riscv32

Mon Jun 12 15:49:11 PDT 2023

phosek marked an inline comment as done.
phosek added a comment.

I wasn't aware of D148797 <https://reviews.llvm.org/D148797>, thanks for the pointer. I'm fine with either landing this one first and refactoring it later, or going directly D148797 <https://reviews.llvm.org/D148797> if you think it's going to land soon.

================
Comment at: libc/config/baremetal/riscv32/entrypoints.txt:86
+set(TARGET_LIBM_ENTRYPOINTS
+    # fenv.h entrypoints
+    # math.h entrypoints
----------------
sivachandra wrote:
> Why not include fenv.h entrypoints?
I omitted those initially because those were failing to build due to a missing malloc, but this was addressed by D152607.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152563/new/

https://reviews.llvm.org/D152563