[libc-commits] [PATCH] D152592: [libc] Place headers in the right include directory

[Joseph Huber via Phabricator via libc-commits]

jhuber6 added inline comments.


================
Comment at: libc/CMakeLists.txt:30
+  endif()
   set(LIBC_LIBRARY_DIR ${LLVM_LIBRARY_OUTPUT_INTDIR}/${LLVM_DEFAULT_TARGET_TRIPLE})
 else()
----------------
sivachandra wrote:
> phosek wrote:
> > @sivachandra When `LIBC_TARGET_ARCHITECTURE_IS_GPU`, would it make sense to use `gpu-none-llvm` instead of `LLVM_DEFAULT_TARGET_TRIPLE`? It seems like we're effectively treating `gpu-none-llvm` as a target triple but I wanted to confirm first before making the change.
> If building for the GPU, I think we want the target triple to be fixed to `gpu-none-llvm` and `LLVM_DEFAULT_TARGET_TRIPLE` does not matter. I will let @jhuber6 to confirm.
Yes, that was a decision to separate these generates GPU headers from the ones that would be used by the system. Since we don't have a single triple we just made one up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152592/new/

https://reviews.llvm.org/D152592