[libc-commits] [PATCH] D152486: [libc] Begin implementing a 'libmgpu.a' for math on the GPU

[Joseph Huber via Phabricator via libc-commits]

jhuber6 added inline comments.


================
Comment at: libc/src/math/gpu/amdgpu/amdgpu.h:18
+namespace __llvm_libc {
+namespace vendor {
+
----------------
elmcdonough wrote:
> Shouldn't this be `internal` to stay consistent with nvptx.h and sin.cpp?  I wasn't able to get this patch to build with the `vendor` namespace, but changing it to `internal` got it to compile.
Yeah that was a mistake I forgot to update


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152486/new/

https://reviews.llvm.org/D152486