[libc-commits] [PATCH] D152592: [libc] Place headers in the right include directory

[Petr Hosek via Phabricator via libc-commits]

phosek added inline comments.


================
Comment at: libc/CMakeLists.txt:30
+  endif()
   set(LIBC_LIBRARY_DIR ${LLVM_LIBRARY_OUTPUT_INTDIR}/${LLVM_DEFAULT_TARGET_TRIPLE})
 else()
----------------
@sivachandra When `LIBC_TARGET_ARCHITECTURE_IS_GPU`, would it make sense to use `gpu-none-llvm` instead of `LLVM_DEFAULT_TARGET_TRIPLE`? It seems like we're effectively treating `gpu-none-llvm` as a target triple but I wanted to confirm first before making the change.


================
Comment at: libc/CMakeLists.txt:34
+    set(LIBC_INCLUDE_DIR ${CMAKE_CURRENT_BINARY_DIR}/include)
     set(LIBC_LIBRARY_DIR ${CMAKE_CURRENT_BINARY_DIR})
   elseif(LLVM_LIBRARY_OUTPUT_INTDIR)
----------------
@sivachandra Would it make sense to use `${CMAKE_CURRENT_BINARY_DIR}/lib` in this case for consistency?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152592/new/

https://reviews.llvm.org/D152592