[libc-commits] [PATCH] D152503: [libc][NFC] Simplify LibcTest and trim down string allocations

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/test/UnitTest/FPMatcher.h:24
 
-template <typename T, __llvm_libc::testing::TestCondition Condition>
+using __llvm_libc::testing::TestCond;
+
----------------
gchatelet wrote:
> sivachandra wrote:
> > Instead of this, I think we can get rid of the `fputil` namespace which is mostly a legacy remnant.
> > Instead of this, I think we can get rid of the `fputil` namespace which is mostly a legacy remnant.
> 
> AFAICT this means removing the `fputil` namespace everywhere correct? If so I will probably do this in a separate patch as it's quite big.
I meant only in the test related components. You can do it separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152503/new/

https://reviews.llvm.org/D152503