[libc-commits] [PATCH] D152503: [libc][NFC] Simplify LibcTest and trim down string allocations

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Jun 9 01:15:14 PDT 2023


sivachandra accepted this revision.
sivachandra added a comment.
This revision is now accepted and ready to land.

LGTM but one comment since you are here anyway.



================
Comment at: libc/test/UnitTest/FPMatcher.h:24
 
-template <typename T, __llvm_libc::testing::TestCondition Condition>
+using __llvm_libc::testing::TestCond;
+
----------------
Instead of this, I think we can get rid of the `fputil` namespace which is mostly a legacy remnant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152503/new/

https://reviews.llvm.org/D152503



More information about the libc-commits mailing list