[libc-commits] [PATCH] D150399: [libc] add options to printf decimal floats

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/src/__support/float_to_string.h:21
+
+#ifdef LIBC_COPT_FLOAT_TO_STR_USE_MEGA_TABLE
+#include "src/__support/ryu_long_double_constants.h"
----------------
michaelrj wrote:
> sivachandra wrote:
> > s/`LIBC_COPT_FLOAT_TO_STR_USE_MEGA_TABLE`/`LIBC_COPT_FLOAT_TO_STR_USE_LARGE_LONG_DOUBLE_TABLE`
> I like the name `MEGA_TABLE` since the table is several megabytes in size. Additionally, when the mega table is enabled it's used for both doubles and long doubles.
You can choose to keep `MEGA` in there but the name should reflect that it is about `long doubles`. So, I suggest to make it: `..._USE_MEGA_LONG_DOUBLE_TABLE`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150399/new/

https://reviews.llvm.org/D150399