[libc-commits] [PATCH] D150399: [libc] add options to printf decimal floats

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added a comment.

Just minor comments but LGTM.



================
Comment at: libc/src/__support/float_to_string.h:21
+
+#ifdef LIBC_COPT_FLOAT_TO_STR_USE_MEGA_TABLE
+#include "src/__support/ryu_long_double_constants.h"
----------------
s/`LIBC_COPT_FLOAT_TO_STR_USE_MEGA_TABLE`/`LIBC_COPT_FLOAT_TO_STR_USE_LARGE_LONG_DOUBLE_TABLE`


================
Comment at: libc/src/__support/float_to_string.h:427
+      val = internal::get_table_positive_df<256>(IDX_SIZE * idx, block_index);
+#elif defined(LIBC_COPT_FLOAT_TO_STR_USE_INT_CALC)
+
----------------
Add commentary about how the options here compare.


================
Comment at: libc/utils/mathtools/ryu_tablegen.py:1
+BLOCK_SIZE = 9
+
----------------
Add comments about usage of this script.


================
Comment at: utils/bazel/llvm-project-overlay/libc/BUILD.bazel:304
     ],
+    # defines = ["LIBC_COPT_FLOAT_TO_STR_USE_MEGA_TABLE"],
     deps = [
----------------
Either remove or add comments about why this is commented out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150399/new/

https://reviews.llvm.org/D150399