[libc-commits] [PATCH] D152283: [libc] Export GPU extensions to `libc` for external use

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/config/gpu/entrypoints.txt:84
+    # gpu/rpc.h entrypoints
+    libc.src.gpu.reset
 )
----------------
The CMake machinery will look for an entrypoint named `reset` but more importantly, `libc-hdrgen` will also look for a function named `reset` in a spec. Since you do not have a function with name `reset`, I would have expected `libc-hdrgen` to error out somewhere. To solve your problem, rename the entrypoint target to match the function name.


================
Comment at: libc/src/gpu/CMakeLists.txt:2
+add_entrypoint_object(
+  reset
+  SRCS
----------------
We have to match the target name with the entrypoint name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152283/new/

https://reviews.llvm.org/D152283