[libc-commits] [PATCH] D152270: [libc] Remove operator T from cpp::expected.

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Jun 6 10:23:43 PDT 2023


sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/__support/File/dir.cpp:23
   __llvm_libc::AllocChecker ac;
-  Dir *dir = new (ac) Dir(fd);
+  Dir *dir = new (ac) Dir(fd.value());
   if (!ac)
----------------
Is using `*fd` more idiomatic?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152270/new/

https://reviews.llvm.org/D152270



More information about the libc-commits mailing list