[libc-commits] [libc] a59e171 - [libc][obvious] Fix conditional when CUDA is not found

Joseph Huber via libc-commits libc-commits at lists.llvm.org
Mon Jun 5 16:51:30 PDT 2023


Author: Joseph Huber
Date: 2023-06-05T18:51:23-05:00
New Revision: a59e1712fa0a3a51097bbf3e1f52531bb4d85475

URL: https://github.com/llvm/llvm-project/commit/a59e1712fa0a3a51097bbf3e1f52531bb4d85475
DIFF: https://github.com/llvm/llvm-project/commit/a59e1712fa0a3a51097bbf3e1f52531bb4d85475.diff

LOG: [libc][obvious] Fix conditional when CUDA is not found

If CUDA is not found this string will expand into nothing. We need to
surround it with a string otherwise it will cause build failures.

Differential Revision: https://reviews.llvm.org/D152209

Added: 
    

Modified: 
    libc/utils/gpu/loader/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libc/utils/gpu/loader/CMakeLists.txt b/libc/utils/gpu/loader/CMakeLists.txt
index dc9ee6fe3523f..a05aa91b9c658 100644
--- a/libc/utils/gpu/loader/CMakeLists.txt
+++ b/libc/utils/gpu/loader/CMakeLists.txt
@@ -15,10 +15,10 @@ find_package(CUDAToolkit QUIET)
 # The CUDA loader requires LLVM to traverse the ELF image for symbols.
 find_package(LLVM QUIET)
 if(CUDAToolkit_FOUND AND LLVM_FOUND AND
-   ${CUDAToolkit_VERSION} VERSION_GREATER_EQUAL "11.2")
+   "${CUDAToolkit_VERSION}" VERSION_GREATER_EQUAL "11.2")
   add_subdirectory(nvptx)
 else()
-  if(${CUDAToolkit_VERSION} VERSION_LESS "11.2")
+  if("${CUDAToolkit_VERSION}" VERSION_LESS "11.2")
     message(WARNING 
       "Skipping CUDA loader for gpu target, CUDA must be version 11.2 or later.
        Found CUDA Version ${CUDAToolkit_VERSION}")


        


More information about the libc-commits mailing list