[libc-commits] [PATCH] D148837: [LIBC] Strengthen `pthread_join` tests; NFC

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Jun 5 12:51:14 PDT 2023


michaelrj added a comment.

I like the general idea of having a more thorough test for pthreads as a whole, but it should probably be in a separate file instead of replacing the `pthread_join` test. I think it would fit better in the `pthread_test` file.



================
Comment at: libc/test/integration/src/pthread/pthread_join_test.cpp:2
+//===-- Tests for pthread_join
+//--------------------------------------------===//
 //
----------------
nit: fix header


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148837/new/

https://reviews.llvm.org/D148837



More information about the libc-commits mailing list