[libc-commits] [PATCH] D151624: [libc][CMake] Place archives in build/lib/<target-triple>

Petr Hosek via Phabricator via libc-commits libc-commits at lists.llvm.org
Sat Jun 3 15:23:10 PDT 2023


phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: libc/cmake/modules/LLVMLibCLibraryRules.cmake:138
   )
   set_target_properties(${target_name}  PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
   target_link_libraries(${target_name}  -nostdlib -lc -lm)
----------------
I think we should use `${LIBC_LIBRARY_DIR}` here as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151624/new/

https://reviews.llvm.org/D151624



More information about the libc-commits mailing list