[libc-commits] [libc] 48bb7bb - [libc] Disable the string_to_float test on NVPTX

Joseph Huber via libc-commits libc-commits at lists.llvm.org
Fri Jun 2 13:56:47 PDT 2023


Author: Joseph Huber
Date: 2023-06-02T15:56:39-05:00
New Revision: 48bb7bb868919a090492bffb9f3c170dae5250eb

URL: https://github.com/llvm/llvm-project/commit/48bb7bb868919a090492bffb9f3c170dae5250eb
DIFF: https://github.com/llvm/llvm-project/commit/48bb7bb868919a090492bffb9f3c170dae5250eb.diff

LOG: [libc] Disable the string_to_float test on NVPTX

This test began failing after recent changes. Disable it for now.

Differential Revision: https://reviews.llvm.org/D152032

Added: 
    

Modified: 
    libc/test/src/__support/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libc/test/src/__support/CMakeLists.txt b/libc/test/src/__support/CMakeLists.txt
index f833617578c81..13a6c3f1a84f4 100644
--- a/libc/test/src/__support/CMakeLists.txt
+++ b/libc/test/src/__support/CMakeLists.txt
@@ -20,7 +20,7 @@ add_libc_test(
     libc.src.__support.common
 )
 
-# This test fails with a segmentation fault on NVPTX.
+# These tests fails with an illegal instruction
 if(NOT LIBC_GPU_TARGET_ARCHITECTURE_IS_NVPTX)
   add_libc_test(
     high_precision_decimal_test
@@ -32,19 +32,19 @@ if(NOT LIBC_GPU_TARGET_ARCHITECTURE_IS_NVPTX)
       libc.src.__support.high_precision_decimal
       libc.src.__support.uint128
   )
-endif()
 
-add_libc_test(
-  str_to_float_test
-  SUITE
-    libc-support-tests
-  SRCS
-    str_to_float_test.cpp
-  DEPENDS
-    libc.src.__support.str_to_float
-    libc.src.__support.uint128
-    libc.src.errno.errno
-)
+  add_libc_test(
+    str_to_float_test
+    SUITE
+      libc-support-tests
+    SRCS
+      str_to_float_test.cpp
+    DEPENDS
+      libc.src.__support.str_to_float
+      libc.src.__support.uint128
+      libc.src.errno.errno
+  )
+endif()
 
 add_libc_test(
   integer_to_string_test


        


More information about the libc-commits mailing list