[libc-commits] [PATCH] D152032: [libc] Disable the string_to_float test on NVPTX

[Joseph Huber via Phabricator via libc-commits]

jhuber6 created this revision.
Herald added subscribers: libc-commits, mattd, gchakrabarti, asavonic, tschuett.
Herald added projects: libc-project, All.
jhuber6 requested review of this revision.

This test began failing after recent changes. Disable it for now.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D152032

Files:
  libc/test/src/__support/CMakeLists.txt


Index: libc/test/src/__support/CMakeLists.txt
===================================================================
--- libc/test/src/__support/CMakeLists.txt
+++ libc/test/src/__support/CMakeLists.txt
@@ -20,7 +20,7 @@
     libc.src.__support.common
 )
 
-# This test fails with a segmentation fault on NVPTX.
+# These tests fails with an illegal instruction
 if(NOT LIBC_GPU_TARGET_ARCHITECTURE_IS_NVPTX)
   add_libc_test(
     high_precision_decimal_test
@@ -32,19 +32,19 @@
       libc.src.__support.high_precision_decimal
       libc.src.__support.uint128
   )
-endif()
 
-add_libc_test(
-  str_to_float_test
-  SUITE
-    libc-support-tests
-  SRCS
-    str_to_float_test.cpp
-  DEPENDS
-    libc.src.__support.str_to_float
-    libc.src.__support.uint128
-    libc.src.errno.errno
-)
+  add_libc_test(
+    str_to_float_test
+    SUITE
+      libc-support-tests
+    SRCS
+      str_to_float_test.cpp
+    DEPENDS
+      libc.src.__support.str_to_float
+      libc.src.__support.uint128
+      libc.src.errno.errno
+  )
+endif()
 
 add_libc_test(
   integer_to_string_test


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152032.527965.patch
Type: text/x-patch
Size: 1078 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230602/ae08a052/attachment.bin>