[libc-commits] [PATCH] D153395: Populating 'libmgpu.a' for math on the GPU

Mon Jul 31 16:54:03 PDT 2023

arsenm added a comment.

In D153395#4548960 <https://reviews.llvm.org/D153395#4548960>, @jhuber6 wrote:

> In D153395#4548955 <https://reviews.llvm.org/D153395#4548955>, @arsenm wrote:
>
>> In D153395#4548952 <https://reviews.llvm.org/D153395#4548952>, @AntonRydahl wrote:
>>
>>> We found that `__builtin_nextafter` and `__builtin_nextafter` were not correctly lowered. Therefore, they have been replaced with vendor versions.
>>
>> nextafter isn't that complicated to implement, could just write one
>
> The `libc` library has a generic version that's most likely suitable to use. If we just list `nextafter` in `entrypoints.txt` but do not provide a vendor or gpu implementation it should be used.

Looks a branchy/early-returny in ways the optimizer isn't aggressive enough at speculating

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153395/new/

https://reviews.llvm.org/D153395