[libc-commits] [PATCH] D156388: [libc] _INCLUDE_SCUDO: check for compiler-rt in enabled RUNTIMES too

Alfred Persson Forsberg via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Jul 26 18:34:59 PDT 2023


alfredfo created this revision.
alfredfo added reviewers: michaelrj, sivachandra, thesamesam.
Herald added subscribers: libc-commits, yaneury, Chia-hungDuan, cryptoad, dberris.
Herald added projects: libc-project, All.
alfredfo requested review of this revision.

Previously including SCUDO in a libc build with runtimes/ as root was
not possible since this code only checked for compiler-rt enabled via
LLVM_ENABLED_PROJECTS.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D156388

Files:
  libc/CMakeLists.txt


Index: libc/CMakeLists.txt
===================================================================
--- libc/CMakeLists.txt
+++ libc/CMakeLists.txt
@@ -164,7 +164,7 @@
 
 option(LLVM_LIBC_INCLUDE_SCUDO "Include the SCUDO standalone as the allocator for LLVM libc" OFF)
 if(LLVM_LIBC_INCLUDE_SCUDO)
-  if (NOT "compiler-rt" IN_LIST LLVM_ENABLE_PROJECTS)
+  if (NOT ("compiler-rt" IN_LIST LLVM_ENABLE_PROJECTS OR "compiler-rt" IN_LIST LLVM_ENABLE_RUNTIMES))
     message(FATAL_ERROR "SCUDO cannot be included without adding compiler-rt to LLVM_ENABLE_PROJECTS")
   endif()
 endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156388.544576.patch
Type: text/x-patch
Size: 575 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230727/755e81ca/attachment.bin>


More information about the libc-commits mailing list