[libc-commits] [PATCH] D155121: [libc] Add support for the 'fread' function on the GPU

Johannes Doerfert via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Jul 26 10:15:09 PDT 2023


jdoerfert added a comment.

In D155121#4535879 <https://reviews.llvm.org/D155121#4535879>, @jdoerfert wrote:

> This is what confused me earlier:
> If I read the `fread` definition properly, libc's implementation is wrong. The read is supposed to be quantized, but in libc it is not (or it is quantized with an element size of 1).

Turns out, all libc impl. do this... anyway. With 1 as size on the host side this should do what the host would do, so we should be fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155121/new/

https://reviews.llvm.org/D155121



More information about the libc-commits mailing list