[libc-commits] [PATCH] D156168: [libc][NFC] Simplify assert message generation

Jon Chesterfield via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Jul 24 14:44:36 PDT 2023


JonChesterfield accepted this revision.
JonChesterfield added a reviewer: jhuber6.
JonChesterfield added a comment.
This revision is now accepted and ready to land.

LGTM. I'm slightly surprised `__PRETTY_FUNCTION__` can't be concatenated with string literals at preprocessor time but I'm getting errors when I try it.

This might leak into user code. Is there an existing __LIBC_ prefix or similar?

Thanks for dropping the runtime int -> string conversion, always pleased to have fewer things that can go wrong at runtime.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156168/new/

https://reviews.llvm.org/D156168



More information about the libc-commits mailing list