[libc-commits] [PATCH] D155979: [libc] Disable 'DecodeInOtherBases` test on GPU targets

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Jul 21 11:14:00 PDT 2023


michaelrj accepted this revision.
michaelrj added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/test/src/stdlib/StrtolTest.h:202
   void DecodeInOtherBases(FunctionT func) {
+    // This test is excessively slow on the GPU so we disable it there.
+#if defined(LIBC_TARGET_ARCH_IS_GPU)
----------------
nit: Clarify this comment with the new design


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155979/new/

https://reviews.llvm.org/D155979



More information about the libc-commits mailing list