[libc-commits] [PATCH] D155979: [libc] Disable 'DecodeInOtherBases` test on GPU targets

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Jul 21 10:42:05 PDT 2023


jhuber6 added a comment.

In D155979#4523279 <https://reviews.llvm.org/D155979#4523279>, @michaelrj wrote:

> I'd rather not limit the digits to just 0 and 1. If you want to shorten the tests maybe try 16? Otherwise probably just disable the whole test. Having the test enabled and running but not actually checking anything seems like a recipe for confusion.

Well we at least get the first loop's checks. This version takes 5ms on my machine, the original takes 6000ms, changing it to 16 takes 500ms.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155979/new/

https://reviews.llvm.org/D155979



More information about the libc-commits mailing list