[libc-commits] [PATCH] D155979: [libc] Disable 'DecodeInOtherBases` test on GPU targets

[Joseph Huber via Phabricator via libc-commits]

jhuber6 created this revision.
jhuber6 added reviewers: JonChesterfield, jplehr, tra, sivachandra, lntue, michaelrj.
Herald added projects: libc-project, All.
Herald added a subscriber: libc-commits.
jhuber6 requested review of this revision.
Herald added a subscriber: wangpc.

This test is excessively slow on GPU targets, taking anywhere beween 5
and 60 seconds to complete each time it's run. See
https://lab.llvm.org/buildbot/#/builders/55/builds/52203/steps/12/logs/stdio
for an example on the NVPTX buildbot. Simply disable testing this on the
GPU for now.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D155979

Files:
  libc/test/src/stdlib/StrtolTest.h


Index: libc/test/src/stdlib/StrtolTest.h
===================================================================
--- libc/test/src/stdlib/StrtolTest.h
+++ libc/test/src/stdlib/StrtolTest.h
@@ -8,6 +8,7 @@
 
 #include "src/__support/CPP/limits.h"
 #include "src/__support/CPP/type_traits.h"
+#include "src/__support/macros/properties/architectures.h"
 #include "src/errno/libc_errno.h"
 #include "test/UnitTest/Test.h"
 
@@ -197,6 +198,8 @@
     EXPECT_EQ(str_end - just_space_and_sign, ptrdiff_t(0));
   }
 
+  // This test is excessively slow on the GPU so we disable it there.
+#if !defined(LIBC_TARGET_ARCH_IS_GPU)
   void DecodeInOtherBases(FunctionT func) {
     char small_string[4] = {'\0', '\0', '\0', '\0'};
     for (int base = 2; base <= 36; ++base) {
@@ -292,6 +295,7 @@
       }
     }
   }
+#endif
 
   void CleanBaseSixteenDecode(FunctionT func) {
     char *str_end = nullptr;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155979.542964.patch
Type: text/x-patch
Size: 889 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230721/7ad6dc50/attachment.bin>