[libc-commits] [PATCH] D155812: [libc][amdgpu] Tolerate different install directories for hsa.h

Thu Jul 20 03:37:13 PDT 2023

JonChesterfield added a comment.

This one is useful for building with reference to the HSA source tree, where the headers are in a folder called 'inc'.

I think ROCm has sometimes installed with a leading hsa directory and sometimes not.

The dynamic_hsa setup openmp currently uses in some configurations doesn't have a leading hsa directory at present.

Debian uses /usr/include/hsa/hsa.h at present https://packages.debian.org/sid/amd64/libhsa-runtime-dev/filelist

================
Comment at: libc/utils/gpu/loader/amdgpu/Loader.cpp:30
+#endif

 #include <cstdio>
----------------
^ I'm not sure the defined(__has_include) check is necessary but it doesn't do any harm. This is a copy&paste from the openmp plugin where I think it's been through a few variations. amdgpu-arch used to have the same pattern before https://reviews.llvm.org/D150807.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155812/new/

https://reviews.llvm.org/D155812