[libc-commits] [PATCH] D155597: [libc][memfunctions] Explicit error when platform in not supported

[Matt Arsenault via Phabricator via libc-commits]

arsenm added a comment.

In D155597#4514709 <https://reviews.llvm.org/D155597#4514709>, @jhuber6 wrote:

> In D155597#4513903 <https://reviews.llvm.org/D155597#4513903>, @gchatelet wrote:
>
>> Thx for checking the patch!
>> @jhuber6 any chance you can add the `libc` tag to the bot? That would be helpful.
>>
>> Also I'd be happy to add GPU specific implementations but I'm not too familiar with the specifics of these architectures. Let me know if you already have optimized versions on your side and I can try to integrate them.
>
> According to @arsenm, for the GPU these should just map to intrinsics, but I don't have a good view of the benefits of having something impolemented in source, vs leaving it to the backend.

These should just emit llvm.{memcpy|memmove|memset}. If you implemented it source ideally we would pattern recognize it into the intrinsics


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155597/new/

https://reviews.llvm.org/D155597