[libc-commits] [PATCH] D155597: [libc][memfunctions] Explicit error when platform in not supported

Tue Jul 18 09:11:15 PDT 2023

gchatelet added a comment.

In D155597#4510934 <https://reviews.llvm.org/D155597#4510934>, @JonChesterfield wrote:

> I think this has broken amdgpu. Why are author and reviewer the same name?

Normally I would commit such small (and presumably benign) changes without review but I've been told that all libc patches should go through Phabricator.
I made sure to run the patch on all our CI machines before submitting (ARM, aarch64, riscv and x86).

> Broke CI two hours ago. https://lab.llvm.org/staging/#/builders/247/builds/3194

Thx for the heads up.
I'm monitoring https://lab.llvm.org/buildbot/#/grid?tag=libc for breakage when I submit such patches, it seems that `openmp-offload-libc-amdgpu-runtime` is not tagged with `libc`. If you are the maintainer of the build bot can you make sure it is tagged with `libc`?

I still want to make it explicitly visible what platform we support for memory functions. Do I understand correctly that AMDGPU will receive trivial implementations as defined in https://github.com/llvm/llvm-project/blob/main/libc/src/string/memory_utils/generic/byte_per_byte.h. Thx.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155597/new/

https://reviews.llvm.org/D155597