[libc-commits] [libc] 8759f1b - Revert "[libc] Default the GPU build to the default memory utilities"

[Joseph Huber via libc-commits]

Author: Joseph Huber
Date: 2023-07-18T11:01:38-05:00
New Revision: 8759f1b03083c856053c4fae9b9da66f9b34af94

URL: https://github.com/llvm/llvm-project/commit/8759f1b03083c856053c4fae9b9da66f9b34af94
DIFF: https://github.com/llvm/llvm-project/commit/8759f1b03083c856053c4fae9b9da66f9b34af94.diff

LOG: Revert "[libc] Default the GPU build to the default memory utilities"

This reverts commit eca8b54a5f76c65a055bac05556b70c2a0ec63a1.

Another user reverted the patch this was based on leaving this one in a
broken state.

Added: 
    

Modified: 
    libc/src/string/memory_utils/bcmp_implementations.h
    libc/src/string/memory_utils/memcmp_implementations.h
    libc/src/string/memory_utils/memcpy_implementations.h
    libc/src/string/memory_utils/memmove_implementations.h
    libc/src/string/memory_utils/memset_implementations.h

Removed: 
    


################################################################################
diff  --git a/libc/src/string/memory_utils/bcmp_implementations.h b/libc/src/string/memory_utils/bcmp_implementations.h
index 4b676e4dccea55..bfd52014325e5c 100644
--- a/libc/src/string/memory_utils/bcmp_implementations.h
+++ b/libc/src/string/memory_utils/bcmp_implementations.h
@@ -23,8 +23,6 @@
 #elif defined(LIBC_TARGET_ARCH_IS_ANY_RISCV)
 #include "src/string/memory_utils/riscv/bcmp_implementations.h"
 #define LIBC_SRC_STRING_MEMORY_UTILS_BCMP inline_bcmp_riscv
-#elif defined(LIBC_TARGET_ARCH_IS_GPU)
-// TODO: Define a more optimal GPU impolementation.
 #else
 // We may want to error instead of defaulting to suboptimal implementation.
 #include "src/string/memory_utils/generic/byte_per_byte.h"

diff  --git a/libc/src/string/memory_utils/memcmp_implementations.h b/libc/src/string/memory_utils/memcmp_implementations.h
index 95889c560c0ffb..e18e64072732c9 100644
--- a/libc/src/string/memory_utils/memcmp_implementations.h
+++ b/libc/src/string/memory_utils/memcmp_implementations.h
@@ -24,8 +24,6 @@
 #elif defined(LIBC_TARGET_ARCH_IS_ANY_RISCV)
 #include "src/string/memory_utils/riscv/memcmp_implementations.h"
 #define LIBC_SRC_STRING_MEMORY_UTILS_MEMCMP inline_memcmp_riscv
-#elif defined(LIBC_TARGET_ARCH_IS_GPU)
-// TODO: Define a more optimal GPU impolementation.
 #else
 // We may want to error instead of defaulting to suboptimal implementation.
 #include "src/string/memory_utils/generic/byte_per_byte.h"

diff  --git a/libc/src/string/memory_utils/memcpy_implementations.h b/libc/src/string/memory_utils/memcpy_implementations.h
index 4e59230e2acb8c..657fbac3177ff5 100644
--- a/libc/src/string/memory_utils/memcpy_implementations.h
+++ b/libc/src/string/memory_utils/memcpy_implementations.h
@@ -28,8 +28,6 @@
 #elif defined(LIBC_TARGET_ARCH_IS_ANY_RISCV)
 #include "src/string/memory_utils/riscv/memcpy_implementations.h"
 #define LIBC_SRC_STRING_MEMORY_UTILS_MEMCPY inline_memcpy_riscv
-#elif defined(LIBC_TARGET_ARCH_IS_GPU)
-// TODO: Define a more optimal GPU impolementation.
 #else
 // We may want to error instead of defaulting to suboptimal implementation.
 #include "src/string/memory_utils/generic/byte_per_byte.h"

diff  --git a/libc/src/string/memory_utils/memmove_implementations.h b/libc/src/string/memory_utils/memmove_implementations.h
index 764ed66ab6dc71..78ae7a88cc457c 100644
--- a/libc/src/string/memory_utils/memmove_implementations.h
+++ b/libc/src/string/memory_utils/memmove_implementations.h
@@ -20,8 +20,6 @@
 #elif defined(LIBC_TARGET_ARCH_IS_ANY_RISCV)
 #include "src/string/memory_utils/riscv/memmove_implementations.h"
 #define LIBC_SRC_STRING_MEMORY_UTILS_MEMMOVE inline_memmove_riscv
-#elif defined(LIBC_TARGET_ARCH_IS_GPU)
-// TODO: Define a more optimal GPU impolementation.
 #else
 // We may want to error instead of defaulting to suboptimal implementation.
 #include "src/string/memory_utils/generic/byte_per_byte.h"

diff  --git a/libc/src/string/memory_utils/memset_implementations.h b/libc/src/string/memory_utils/memset_implementations.h
index bb9317c927093d..37ceff96fce9c3 100644
--- a/libc/src/string/memory_utils/memset_implementations.h
+++ b/libc/src/string/memory_utils/memset_implementations.h
@@ -24,8 +24,6 @@
 #elif defined(LIBC_TARGET_ARCH_IS_ANY_RISCV)
 #include "src/string/memory_utils/riscv/memset_implementations.h"
 #define LIBC_SRC_STRING_MEMORY_UTILS_MEMSET inline_memset_riscv
-#elif defined(LIBC_TARGET_ARCH_IS_GPU)
-// TODO: Define a more optimal GPU impolementation.
 #else
 // We may want to error instead of defaulting to suboptimal implementation.
 #include "src/string/memory_utils/generic/byte_per_byte.h"