[libc-commits] [PATCH] D155615: [libc] Default the GPU build to the default memory utilities

[Joseph Huber via Phabricator via libc-commits]

This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGeca8b54a5f76: [libc] Default the GPU build to the default memory utilities (authored by jhuber6).

Changed prior to commit:
  https://reviews.llvm.org/D155615?vs=541578&id=541580#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155615/new/

https://reviews.llvm.org/D155615

Files:
  libc/src/string/memory_utils/bcmp_implementations.h
  libc/src/string/memory_utils/memcmp_implementations.h
  libc/src/string/memory_utils/memcpy_implementations.h
  libc/src/string/memory_utils/memmove_implementations.h
  libc/src/string/memory_utils/memset_implementations.h


Index: libc/src/string/memory_utils/memset_implementations.h
===================================================================
--- libc/src/string/memory_utils/memset_implementations.h
+++ libc/src/string/memory_utils/memset_implementations.h
@@ -24,6 +24,8 @@
 #elif defined(LIBC_TARGET_ARCH_IS_ANY_RISCV)
 #include "src/string/memory_utils/riscv/memset_implementations.h"
 #define LIBC_SRC_STRING_MEMORY_UTILS_MEMSET inline_memset_riscv
+#elif defined(LIBC_TARGET_ARCH_IS_GPU)
+// TODO: Define a more optimal GPU impolementation.
 #else
 // We may want to error instead of defaulting to suboptimal implementation.
 #include "src/string/memory_utils/generic/byte_per_byte.h"
Index: libc/src/string/memory_utils/memmove_implementations.h
===================================================================
--- libc/src/string/memory_utils/memmove_implementations.h
+++ libc/src/string/memory_utils/memmove_implementations.h
@@ -20,6 +20,8 @@
 #elif defined(LIBC_TARGET_ARCH_IS_ANY_RISCV)
 #include "src/string/memory_utils/riscv/memmove_implementations.h"
 #define LIBC_SRC_STRING_MEMORY_UTILS_MEMMOVE inline_memmove_riscv
+#elif defined(LIBC_TARGET_ARCH_IS_GPU)
+// TODO: Define a more optimal GPU impolementation.
 #else
 // We may want to error instead of defaulting to suboptimal implementation.
 #include "src/string/memory_utils/generic/byte_per_byte.h"
Index: libc/src/string/memory_utils/memcpy_implementations.h
===================================================================
--- libc/src/string/memory_utils/memcpy_implementations.h
+++ libc/src/string/memory_utils/memcpy_implementations.h
@@ -28,6 +28,8 @@
 #elif defined(LIBC_TARGET_ARCH_IS_ANY_RISCV)
 #include "src/string/memory_utils/riscv/memcpy_implementations.h"
 #define LIBC_SRC_STRING_MEMORY_UTILS_MEMCPY inline_memcpy_riscv
+#elif defined(LIBC_TARGET_ARCH_IS_GPU)
+// TODO: Define a more optimal GPU impolementation.
 #else
 // We may want to error instead of defaulting to suboptimal implementation.
 #include "src/string/memory_utils/generic/byte_per_byte.h"
Index: libc/src/string/memory_utils/memcmp_implementations.h
===================================================================
--- libc/src/string/memory_utils/memcmp_implementations.h
+++ libc/src/string/memory_utils/memcmp_implementations.h
@@ -24,6 +24,8 @@
 #elif defined(LIBC_TARGET_ARCH_IS_ANY_RISCV)
 #include "src/string/memory_utils/riscv/memcmp_implementations.h"
 #define LIBC_SRC_STRING_MEMORY_UTILS_MEMCMP inline_memcmp_riscv
+#elif defined(LIBC_TARGET_ARCH_IS_GPU)
+// TODO: Define a more optimal GPU impolementation.
 #else
 // We may want to error instead of defaulting to suboptimal implementation.
 #include "src/string/memory_utils/generic/byte_per_byte.h"
Index: libc/src/string/memory_utils/bcmp_implementations.h
===================================================================
--- libc/src/string/memory_utils/bcmp_implementations.h
+++ libc/src/string/memory_utils/bcmp_implementations.h
@@ -23,6 +23,8 @@
 #elif defined(LIBC_TARGET_ARCH_IS_ANY_RISCV)
 #include "src/string/memory_utils/riscv/bcmp_implementations.h"
 #define LIBC_SRC_STRING_MEMORY_UTILS_BCMP inline_bcmp_riscv
+#elif defined(LIBC_TARGET_ARCH_IS_GPU)
+// TODO: Define a more optimal GPU impolementation.
 #else
 // We may want to error instead of defaulting to suboptimal implementation.
 #include "src/string/memory_utils/generic/byte_per_byte.h"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155615.541580.patch
Type: text/x-patch
Size: 3384 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230718/e8649fc6/attachment-0001.bin>