[libc-commits] [PATCH] D154704: [libc] Enable aliasing on AMDGPU targets

[Joseph Huber via Phabricator via libc-commits]

jhuber6 added inline comments.


================
Comment at: libc/src/__support/common.h:19
 
-// GPU targets do not support aliasing.
-#if defined(LIBC_COPT_PUBLIC_PACKAGING) && defined(LIBC_TARGET_ARCH_IS_GPU)
+// The NVPTX target does not support aliasing.
+#if defined(LIBC_COPT_PUBLIC_PACKAGING) && defined(LIBC_TARGET_ARCH_IS_NVPTX)
----------------
tra wrote:
> PTX did add support for aliases a while back, but we indeed don't use it at the moment.
Ah, probably should've checked the PTX reference. Now if they just made `.section` work outside of debug mode I'd be a happy camper. Guessing this just requires some effort in the backend to support it? Might be worthwhile.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154704/new/

https://reviews.llvm.org/D154704