[libc-commits] [PATCH] D154277: [libc] Set include directories for str_to_float tests

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Jul 5 10:26:20 PDT 2023


michaelrj added inline comments.


================
Comment at: libc/test/src/__support/CMakeLists.txt:126-127
+  libc_system_str_to_float_comparison_test
+  PRIVATE
+    ${LIBC_INCLUDE_DIR}
+)
----------------
This one should not use the `LIBC_INCLUDE_DIR` since it's intended to use the system's libc. This is to allow for accuracy and speed comparisons.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154277/new/

https://reviews.llvm.org/D154277



More information about the libc-commits mailing list