[libc-commits] [libc] f8cf210 - [libc] Remove flaky static assert from RPC interface

Joseph Huber via libc-commits libc-commits at lists.llvm.org
Tue Jul 4 09:06:28 PDT 2023


Author: Joseph Huber
Date: 2023-07-04T11:06:06-05:00
New Revision: f8cf2105760d2dfd58de4ca1c459c5bb1e2802dc

URL: https://github.com/llvm/llvm-project/commit/f8cf2105760d2dfd58de4ca1c459c5bb1e2802dc
DIFF: https://github.com/llvm/llvm-project/commit/f8cf2105760d2dfd58de4ca1c459c5bb1e2802dc.diff

LOG: [libc] Remove flaky static assert from RPC interface

Summary:
This function is intended to only be used on the GPU as a shorthand. The
static assert should only fire if it's called ,but it seems that its
precence can sometimes cause issues and other times not. Simply remove
it as it's causing build problems.

Added: 
    

Modified: 
    libc/src/__support/RPC/rpc.h

Removed: 
    


################################################################################
diff  --git a/libc/src/__support/RPC/rpc.h b/libc/src/__support/RPC/rpc.h
index 4e0b85b6da7168..9c39cd2ccbc815 100644
--- a/libc/src/__support/RPC/rpc.h
+++ b/libc/src/__support/RPC/rpc.h
@@ -435,7 +435,6 @@ LIBC_INLINE void Port<T, S>::recv_and_send(W work) {
 /// thread private pointers to the underlying value.
 template <bool T, typename S>
 LIBC_INLINE void Port<T, S>::send_n(const void *src, uint64_t size) {
-  static_assert(is_process_gpu(), "Only valid when running on the GPU");
   const void **src_ptr = &src;
   uint64_t *size_ptr = &size;
   send_n(src_ptr, size_ptr);


        


More information about the libc-commits mailing list