[libc-commits] [PATCH] D153729: [libc] Correct usage of __unix__ and __linux__

Sam James via Phabricator via libc-commits libc-commits at lists.llvm.org
Sun Jul 2 17:08:56 PDT 2023


thesamesam added a comment.

In D153729#4450489 <https://reviews.llvm.org/D153729#4450489>, @michaelrj wrote:

> LGTM, and if there are spots where both linux and macos should be accepted then we should probably make those `#if defined(__linux__) || defined(__APPLE__)`

Yeah, definitely, or it'll end up biting us later on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153729/new/

https://reviews.llvm.org/D153729



More information about the libc-commits mailing list