[libc-commits] [PATCH] D143005: [libc] Build two different static archives libc.a and libm.a under full build.

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/lib/CMakeLists.txt:1-3
+set(libc_archive_targets "")
+set(libc_archive_names "")
+set(libc_archive_entrypoint_lists "")
----------------
jhuber6 wrote:
> Is this necessary? Won't CMake just create an empty one if it doesn't exist?
Yes, in most contexts that is correct. But, I just do it as a practice because we cannot really control var-name leakage from the parent. As in, if the parent uses the same names for its local logic, they will come here already initialized to some value. As a policy though, we name vars having global semantics in `UPPER_SNAKE_CASE`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143005/new/

https://reviews.llvm.org/D143005