[libc-commits] [PATCH] D142776: [libc] Add code for detecting NVIDIA GPUs as well

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.


================
Comment at: libc/cmake/modules/prepare_libc_gpu_build.cmake:53
+                 "architecture ${LIBC_GPU_TARGET_ARCHITECTURE} ")
+  return()
+endif()
----------------
jhuber6 wrote:
> sivachandra wrote:
> > How can one pick between AMD or Nvidia GPUs?
> I wasn't sure if it warranted a special case right now. Since this is a contingency for a system with both an Nvidia and AMD GPU installed, which is uncommon but not unheard of. Right now I wasn't sure how much effort it would be to support testing multiple builds at the same time, so I figured it would be easier to just stick with one for now.
> 
> I could maybe make an override flag. Maybe that would also be useful for ensuring the tests get built even without a GPU installed (as would be the case if someone build LLVM on a cluster's home node and then switched to a compute node).
> Maybe that would also be useful for ensuring the tests get built even without a GPU installed (as would be the case if someone build LLVM on a cluster's home node and then switched to a compute node).

You don't need to address this in this patch but I had this exact use case in mind.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142776/new/

https://reviews.llvm.org/D142776