[libc-commits] [PATCH] D142495: [libc] add scanf current position conversion

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/src/stdio/scanf_core/current_pos_converter.cpp:19
+namespace scanf_core {
+int convert_current_pos(Reader *reader, const FormatSection &to_conv) {
+  write_int_with_length(reader->chars_read(), to_conv);
----------------
lntue wrote:
> This function is quite short.  Will it get more complicated later?  Otherwise you can inline it in the header instead.
I moved it to the header and also tagged it as `LIBC_INLINE`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142495/new/

https://reviews.llvm.org/D142495