[libc-commits] [PATCH] D142515: [libc] fix strtointmax tests

[Michael Jones via Phabricator via libc-commits]

michaelrj created this revision.
michaelrj added reviewers: sivachandra, lntue.
Herald added subscribers: libc-commits, ecnelises, tschuett.
Herald added projects: libc-project, All.
michaelrj requested review of this revision.

The strtointmax tests weren't running because they depend on the same
shared logic as strtol tests and the target for that was being defined
after the inttypes targets, causing them to be skipped. This patch moves
the inttypes test directory later in the order so that the shared tests
are defined before inttypes tests try to use them.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D142515

Files:
  libc/test/src/CMakeLists.txt
  libc/test/src/inttypes/CMakeLists.txt


Index: libc/test/src/inttypes/CMakeLists.txt
===================================================================
--- libc/test/src/inttypes/CMakeLists.txt
+++ libc/test/src/inttypes/CMakeLists.txt
@@ -8,7 +8,7 @@
     strtoimax_test.cpp
   DEPENDS
     libc.src.inttypes.strtoimax
-    libc.test.stdlib.strtol_test_support
+    libc.test.src.stdlib.strtol_test_support
 )
 
 add_libc_unittest(
@@ -19,7 +19,7 @@
     strtoumax_test.cpp
   DEPENDS
     libc.src.inttypes.strtoumax
-    libc.test.stdlib.strtol_test_support
+    libc.test.src.stdlib.strtol_test_support
 )
 
 add_libc_unittest(
Index: libc/test/src/CMakeLists.txt
===================================================================
--- libc/test/src/CMakeLists.txt
+++ libc/test/src/CMakeLists.txt
@@ -30,10 +30,10 @@
 add_subdirectory(ctype)
 add_subdirectory(errno)
 add_subdirectory(fenv)
-add_subdirectory(inttypes)
 add_subdirectory(math)
 add_subdirectory(string)
 add_subdirectory(stdlib)
+add_subdirectory(inttypes)
 add_subdirectory(stdio)
 
 if(${LIBC_TARGET_OS} STREQUAL "linux")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142515.491951.patch
Type: text/x-patch
Size: 1056 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230125/0c2ed11f/attachment-0001.bin>