[libc-commits] [PATCH] D142509: [libc][NFC] Another round of replacement of "inline" with "LIBC_INLINE".

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Jan 24 15:06:50 PST 2023


sivachandra added inline comments.


================
Comment at: libc/src/__support/OSUtil/linux/syscall.h:26
 template <typename... Ts>
-__attribute__((always_inline)) inline long syscall_impl(long __number,
-                                                        Ts... ts) {
+LIBC_INLINE long syscall_impl(long __number, Ts... ts) {
   static_assert(sizeof...(Ts) <= 6, "Too many arguments for syscall");
----------------
michaelrj wrote:
> do we want to keep the `always_inline` attribute?
I don't think we need it. At sufficient optimization levels, just the `inline` tag is sufficient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142509/new/

https://reviews.llvm.org/D142509



More information about the libc-commits mailing list