[libc-commits] [PATCH] D142154: [libc][NFC] Replace static inline and inline annotations with LIBC_INLINE.
Siva Chandra via Phabricator via libc-commits
libc-commits at lists.llvm.org
Fri Jan 20 15:18:57 PST 2023
sivachandra added inline comments.
================
Comment at: libc/src/__support/FPUtil/aarch64/FEnvImpl.h:54
- static inline uint32_t getStatusValueForExcept(int excepts) {
+ LIBC_INLINE uint32_t getStatusValueForExcept(int excepts) {
return (excepts & FE_INVALID ? INVALID : 0) |
----------------
abrachet wrote:
> I'm seeing build errors. I think these methods should have been kept `static`. WDYT?
You are correct. The bot isn't showing them!! I will fix this ASAP.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142154/new/
https://reviews.llvm.org/D142154
More information about the libc-commits
mailing list