[libc-commits] [PATCH] D142108: [libc][NFC] Detect host CPU features using try_compile instead of try_run.

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet added a comment.

Thx for the review.

> I think the explicit listing is probably a better approach. As this get more complicated, the CMake scripting will get more complicated. I prefer simpler CMake scripting over increased verbosity/repetitiveness.

I fail to understand this comment. The first part seems to suggest to keep the patch as-is but AFAIU the second part suggests to use CMake scripting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142108/new/

https://reviews.llvm.org/D142108