[libc-commits] [PATCH] D141236: [libc] Implement str{,n}casecmp

[Alex Brachet via Phabricator via libc-commits]

abrachet marked 2 inline comments as done.
abrachet added inline comments.


================
Comment at: libc/test/src/string/strcasecmp_test.cpp:28
+  // This should be '\0' - 'a' = -97
+  ASSERT_EQ(result, -97);
+
----------------
sivachandra wrote:
> Does comparing with the exact difference tightly couple this test with implementation details?
> Does comparing with the exact difference tightly couple this test with implementation details?

Yes, FWIW I copied these verbatim from the strcmp tests. But I've changed the test here to use LT or GT relative to 0.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141236/new/

https://reviews.llvm.org/D141236