[libc-commits] [PATCH] D141235: [libc] Templatize str{,n}cmp

[Alex Brachet via Phabricator via libc-commits]

abrachet added inline comments.


================
Comment at: libc/src/string/memory_utils/strcmp_implementations.h:20
+  // TODO: Look at benefits for comparing words at a time.
+  for (; *left && !comp(*left, *right); ++left, ++right)
+    ;
----------------
lntue wrote:
> Will there be a problem with signed-ness difference between `char` and `unsigned char` in lines 20 vs 22?
I don't really know, this is just how it was before and I copied verbatim other than using the comparator function


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141235/new/

https://reviews.llvm.org/D141235