[libc-commits] [PATCH] D141235: [libc] Templatize str{,n}cmp

[Tue Ly via Phabricator via libc-commits]

lntue added inline comments.


================
Comment at: libc/src/string/memory_utils/strcmp_implementations.h:20
+  // TODO: Look at benefits for comparing words at a time.
+  for (; *left && !comp(*left, *right); ++left, ++right)
+    ;
----------------
Will there be a problem with signed-ness difference between `char` and `unsigned char` in lines 20 vs 22?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141235/new/

https://reviews.llvm.org/D141235