[libc-commits] [PATCH] D141162: [libc] add internal string class

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/src/__support/CPP/vector_string.h:24
+
+class VectorString {
+  static constexpr size_t INIT_BUFF_SIZE = 64;
----------------
sivachandra wrote:
> Shouldn't this be named `string`?
I talked about it in my comment on the patch this was split out of but basically it has some differences from `std::string` that might warrant a different name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141162/new/

https://reviews.llvm.org/D141162