[libc-commits] [PATCH] D141112: [libc] Add a separate install target for the libc static archives.
Michael Jones via Phabricator via libc-commits
libc-commits at lists.llvm.org
Fri Jan 6 13:53:30 PST 2023
michaelrj accepted this revision.
michaelrj added a comment.
This revision is now accepted and ready to land.
LGTM with one minor nit
================
Comment at: libc/CMakeLists.txt:166
set(LIBC_COMPONENT libc)
- set(LIBC_INSTALL_DEPENDS "libc;install-libc-headers;libc-startup")
+ set(libc_sub_install_targets "install-libc-static-archives;install-libc-headers")
+ if(NOT LIBC_TARGET_OS_IS_BAREMETAL)
----------------
Nit: `libc_sub_install_targets` seems like it should be capitalized to match the other variables next to it
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141112/new/
https://reviews.llvm.org/D141112
More information about the libc-commits
mailing list