[libc-commits] [PATCH] D141041: [libc] Mark public C++ functions noexcept

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet abandoned this revision.
gchatelet added a subscriber: michaelrj.
gchatelet added a comment.

In D141041#4028944 <https://reviews.llvm.org/D141041#4028944>, @abrachet wrote:

> These aren't the public headers, so this is only marking it noexcept in a context where we likely already build without exceptions. We also don't every query if a function is noexcept in the code base either for the same reason. So I'm not sure what this is accomplishing.

Correct. @michaelrj patch <https://reviews.llvm.org/D141095> is the correct approach in this case then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141041/new/

https://reviews.llvm.org/D141041