[libc-commits] [PATCH] D141095: [libc] add noexcept to external function headers

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Jan 5 15:41:24 PST 2023


sivachandra added inline comments.


================
Comment at: libc/include/__llvm-libc-common.h:35
 
+#undef _Noexcept
+#define _Noexcept noexcept
----------------
Nit: The other names like `_Noreturn` are actually C keywords. In this case, though the identifier names prefixed with `_<Capital letter>` are allowed for standard library use, we should probably obscure this a little more into `__NOEXCEPT` similar to `__BEGIN_C_DECLS`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141095/new/

https://reviews.llvm.org/D141095



More information about the libc-commits mailing list