[libc-commits] [PATCH] D140981: [libc][NFC] Use a function instead of templated static member functions for TYPE_DESC

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet created this revision.
gchatelet added a reviewer: michaelrj.
Herald added subscribers: libc-commits, ecnelises, tschuett.
Herald added projects: libc-project, All.
gchatelet requested review of this revision.

I'm surprised that clang accepts the current code.
It seems odd to me to specialize templated static member variables.

GCC rejects them: https://godbolt.org/z/3ecE9Ps7T

This patch is in the context of https://github.com/llvm/llvm-project/issues/59368


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D140981

Files:
  libc/src/stdio/printf_core/CMakeLists.txt
  libc/src/stdio/printf_core/parser.cpp
  libc/src/stdio/printf_core/parser.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140981.486262.patch
Type: text/x-patch
Size: 7552 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230104/84fc4a38/attachment-0001.bin>